#2227: transaction.commit()/rollback() should be aware of nested calls to
transaction.managed(True)
-------------------------------------+-------------------------------------
     Reporter:  mderk@…              |                    Owner:  nobody
         Type:  New feature          |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:  transaction, nest,   |      Needs documentation:  0
  scope, nested, rollback, commit    |  Patch needs improvement:  1
    Has patch:  1                    |                    UI/UX:  0
  Needs tests:  0                    |
Easy pickings:  0                    |
-------------------------------------+-------------------------------------

Comment (by anonymous):

 As a naive user I'd very much like to see the save point scheme, it
 produces the behavior I was naively expecting.

 To be clear that behavior is:

 If I exception out of a commit_on_success then everything inside that gets
 scrubbed regardless of whether my caller was also in a commit_on_success.
 And if they were in a commit_on_success then without messing it up for
 them.

 I shouldn't need to know if a function I call uses transactions inside and
 I shouldn't need to know if whoever called me uses transactions. Both
 those lead to unpleasant surprises.

 It doesn't seem like it should be a big deal to implement, on entry if
 there's no transaction create one, otherwise drop a savepoint. On exit if
 we created a transaction then commit it. On exception exit roll back to
 the transaction/savepoint we created.

 I agree with the desire to preserve backward compatibility, creating a new
 decorator with this behavior and providing a global flag to enable errors
 when nesting the current ones would address that. I also like atomic for
 the name of the new decorator.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/2227#comment:33>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to