#18929: CachedFilesMixin is not compatible with S3BotoStorage
-------------------------------------+-------------------------------------
     Reporter:  idanzalz@…           |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  contrib.staticfiles  |                  Version:  1.4
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
    Has patch:  1                    |  Unreviewed
  Needs tests:  0                    |      Needs documentation:  0
Easy pickings:  0                    |  Patch needs improvement:  0
                                     |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by anonymous):

 There isn't really that much to add. The storage's url method result gets
 wrapped with unquote when using the CachedFilesMixin.
 This sometimes produces a wrong url for the S3BotoStorage, since the
 Signature part in the url may contain %2B which is translated to '+' by
 unquote and then you get an authentication error from AWS when trying to
 remove it.

 Calling unquote on the url seems like a side effect of the
 CachedFilesMixin that has no connection to what it's supposed to do so I
 think it should be removed.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/18929#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to