#19057: mod_wsgi authentication handlers fail with custom user model
---------------------------------+------------------------------------
     Reporter:  russellm         |                    Owner:  nobody
         Type:  Bug              |                   Status:  reopened
    Component:  contrib.auth     |                  Version:  master
     Severity:  Release blocker  |               Resolution:
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  1                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+------------------------------------
Changes (by ptone):

 * stage:  Ready for checkin => Accepted


Comment:

 This should hopefully address point 1:

 https://github.com/ptone/django/commit/a1da92acb9fb0fa095ad850a3e575071804cdffc

 But I'm unclear as to point 2

 There are lots of places in the test suite that still refer to a hard
 coded django.contrib.auth.models.User

 We still need to have our coverage for the default user model, and it
 doesn't harmful to leave those concrete references in tests as long as the
 custom user option is also tested.

 Are you suggesting we adopt the same {{{UserModel = auth.get_user_model}}}
 pattern for all test code that test user behavior?  That would seem to
 leave the default user model untested if run in a project with a custom
 auth user.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/19057#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to