#18484: csrfmiddlewaretoken enclosed in redundant invisible div
---------------------------------+------------------------------------
     Reporter:  hedleyroos@…     |                    Owner:  nobody
         Type:  Uncategorized    |                   Status:  reopened
    Component:  Forms            |                  Version:  1.4
     Severity:  Release blocker  |               Resolution:
     Keywords:  csrf             |             Triage Stage:  Accepted
    Has patch:  0                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+------------------------------------

Comment (by lukeplant):

 Replying to [comment:3 simonb]:
 > By removing style="display:none" the layout of every form that uses
 csrf_token has been changed. The div becomes significant to the
 layout/flow of the form and moves everything that follows below it - divs
 are blocks.

 Could you give an example of a layout where this happens? (You could use
 jsfiddle e.g. http://jsfiddle.net/abXgB/ ) That would help us assess
 whether this is badly designed or fairly unlikely CSS.

 > Could we, at least, give the surrounding div an id or class so we can
 address it in CSS to fix the layout of all of our forms?

 That sounds fine to me. It may be the easiest option for us given the
 other constraints.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/18484#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to