#18458: Method session.get_expiry_age() does not return what the doc says
-------------------------------------+-------------------------------------
     Reporter:  martin.bouladour@…   |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  contrib.sessions     |                  Version:  1.4
     Severity:  Normal               |               Resolution:  fixed
     Keywords:  session expiration   |             Triage Stage:  Accepted
  expiry age get_expiry_age          |      Needs documentation:  0
    Has patch:  0                    |  Patch needs improvement:  0
  Needs tests:  0                    |                    UI/UX:  0
Easy pickings:  0                    |
-------------------------------------+-------------------------------------

Comment (by Aymeric Augustin <aymeric.augustin@…>):

 In [changeset:"845d8408e7aa09a63c98f160b2c6bc9fa6dbb20f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="845d8408e7aa09a63c98f160b2c6bc9fa6dbb20f"
 [1.5.x] Added optional kwargs to get_expiry_age/date.

 This change allows for cleaner tests: we can test the exact output.

 Refs #18194: this change makes it possible to compute session expiry
 dates at times other than when the session is saved.

 Fixed #18458: the existence of the `modification` kwarg implies that you
 must pass it to get_expiry_age/date if you call these functions outside
 of a short request - response cycle (the intended use case).

 Backport of cd17a24 from master.
 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/18458#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to