#6903: Go back to old change_list view after hitting save
-------------------------------+------------------------------------
     Reporter:  jarrow         |                    Owner:
         Type:  New feature    |                   Status:  new
    Component:  contrib.admin  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:  admin          |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  1
  Needs tests:  0              |  Patch needs improvement:  1
Easy pickings:  1              |                    UI/UX:  1
-------------------------------+------------------------------------

Comment (by akaariai):

 Two comments:
   1. Is there possibility of malicious use of the RETURN_GET_PARAM, that
 is you could send a link of edit_something?_return_to=evil.com
   2. There is some repeating of this:
 {{{
 if RETURN_GET_PARAM in request.GET:
     url += '?%s=%s' % (RETURN_GET_PARAM,
 urlquote(request.GET.get(RETURN_GET_PARAM, '')))
 }}}
 seems like a little helper method could make this a little more DRY.

 This is just after quick skimming, no full review done.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/6903#comment:52>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to