#19327: Admin doesn't handle double login attempts
-------------------------------------+-------------------------------------
Reporter: KJ | Owner: KJ
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
sensitive_post_parameters, login | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 1 |
-------------------------------------+-------------------------------------
Changes (by KJ):
* cc: KJ (added)
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
Comment:
+1 for adupin's argumentation about the if statement.
I think that tests for this ticket should be placed in admin_views, not in
admin_custom_urls, so I've put one there and updated the pull request.
Checking of error message is included. I didn't actually use adupin's
patch because tests in admin_views are written in a different manner.
BTW, I didn't write a test at first because I didn't notice that those are
actually present for the admin. The documentation says tests for contrib
apps live in django/contrib/<app>/tests - I'll create another ticket about
that.
--
Ticket URL: <https://code.djangoproject.com/ticket/19327#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit https://groups.google.com/groups/opt_out.
