#19385: Add support for multiple-column join -------------------------------------+------------------------------------- Reporter: cseibert | Owner: nobody Type: New feature | Status: new Component: Database layer | Version: 1.4 (models, ORM) | Resolution: Severity: Normal | Triage Stage: Accepted Keywords: join | Needs documentation: 0 Has patch: 1 | Patch needs improvement: 1 Needs tests: 0 | UI/UX: 0 Easy pickings: 0 | -------------------------------------+-------------------------------------
Comment (by akaariai): On a quick glance, looks good! However, I don't think we want to add a new field to contrib. We either want to make ForeignKey work with multicolumn joins (even if there is no possibility for multicolumn PKs yet) or we want to leave the multicolumn foreign key implementation to external apps. We are basically in plumbing stage here - we are improving the internals. After done, the patch that adds the support in public APIs should be somewhat more manageable. Still, I think it is worth it to test the internals. So, maybe we could add the contrib field in a test module instead? Making ForeignKeys work properly will likely need the virtual fields support koniiiik has been working on. We really should wait and see if he can continue his work. In any case, the branch contains multiple improvements that we should get committed. Likely the whole stuff targeting models/sql and fields is good to go. I will try to find the time to review the patch as soon as possible. -- Ticket URL: <https://code.djangoproject.com/ticket/19385#comment:22> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.