On Wed, Jan 12, 2011 at 6:23 AM, Russell Keith-Magee
<russ...@keith-magee.com> wrote:
> On Thu, Jan 6, 2011 at 5:29 AM, Ian Clelland <clell...@gmail.com> wrote:
>> Hi,
>>
>> I've been using Simon Willison's QuerySetManager[1] pattern for a
>> while now, and since upgrading to Django 1.2.4, it has been breaking
>> when I try to call a method on a RelatedManager constructed from it.
>>
>> There was a change in r14389 (14390 in the 1.2.X branch) which causes
>> this code to break -- where there was a simple delegation before from
>> the RelatedManager to the QuerySetManager to the model, there now
>> appears to be an infinite recursion, with the RelatedManager and
>> QuerySetManager trying to call each other's get_query_set methods.
>>
>> Has anybody seen this before? I am presuming that the change to
>> Django's related.py is correct, and that the QuerySetManager code just
>> needs to be updated to properly support Multi-db, but I don't know
>> where to start fixing it.
>
> Hi Ian,
>
> Sorry for taking so long to get back to you.
>
> No - I haven't seen this before; and I can't see an obvious reason
> that the snippet should have stopped working.
>
> If you want to make sure this is addressed, you should open a ticket
> in Trac. What you are report is an apparent regression in a recent
> changeset, so it would constitute a release-blocking bug for 1.3.

Thanks, Russ --

Looking at the QuerySetManager code, I couldn't tell if it was even
doing the right thing by unconditionally overriding __getattr__, or if
that was an incorrect solution that just happened to work until
related.py was fixed.

I've posted it on Trac, as ticket #15062.

(Glad to know it wasn't just lost in the noise :) )

Regards,
Ian Clelland
<clell...@gmail.com>

-- 
You received this message because you are subscribed to the Google Groups 
"Django users" group.
To post to this group, send email to django-us...@googlegroups.com.
To unsubscribe from this group, send email to 
django-users+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-users?hl=en.

Reply via email to