On Tue, Nov 19, 2024 at 05:12:18PM +0100, Martin Wilck wrote:
> Only multipathd needs to take care of notifying systemd. There's
> no need to track this information in struct config, or to limit our
> checker interval to it, as checkerloop() wakes up every second anyway.
> 
> While at it, fix the watchdog enablement logic:
> 
> - the watchdog should only be active if WATCHDOG_PID is either unset,
>   or matches the daemon's PID, and if WATCHDOG_USEC is not 0.
> - the watchdog should trigger twice per systemd-set interval.
> - if WatchdogSec= is set to an unreasonable value, make a smarter
>   choice than just disabling the watchdog, and print a more meaningful
>   error message.
> 
> Use timestamp comparison to make sure the watchdog is triggered even
> if a checkerloop iteration takes more than a second.
> 
> Signed-off-by: Martin Wilck <[email protected]>

Reviewed-by: Benjamin Marzinski <[email protected]>


Reply via email to