On Mon, May 12, 2025 at 09:19:23AM +0800, Yu Kuai wrote:
> +static void llbitmap_unplug(struct mddev *mddev, bool sync)
> +{
> + DECLARE_COMPLETION_ONSTACK(done);
> + struct llbitmap *llbitmap = mddev->bitmap;
> + struct llbitmap_unplug_work unplug_work = {
> + .llbitmap = llbitmap,
> + .done = &done,
> + };
> +
> + if (!llbitmap_dirty(llbitmap))
> + return;
> +
> + INIT_WORK_ONSTACK(&unplug_work.work, llbitmap_unplug_fn);
> + queue_work(md_llbitmap_unplug_wq, &unplug_work.work);
> + wait_for_completion(&done);
> + destroy_work_on_stack(&unplug_work.work);
Why is this deferring the work to a workqueue, but then synchronously
waits on it?
