One file per vendor, or device, is a bit excessive for two-four rules.
If possible, select round-robin (>=5.1), or queue-depth (>=6.11). round-robin is a basic selector, and only works well under ideal conditions. A nvme benchmark, round-robin vs queue-depth, shows how bad it is: https://marc.info/?l=linux-kernel&m=171931850925572 https://marc.info/?l=linux-kernel&m=171931852025575 https://github.com/johnmeneghini/iopolicy/?tab=readme-ov-file#sample-data https://people.redhat.com/jmeneghi/ALPSS_2023/NVMe_QD_Multipathing.pdf [ctrl_loss_tmo default value is 600 (ten minutes)] v2: - fix ctrl_loss_tmo commnent - add Infinidat/InfiniBox Cc: Wayne Berthiaume <[email protected]> Cc: Vasuki Manikarnike <[email protected]> Cc: Matthias Rudolph <[email protected]> Cc: Martin George <[email protected]> Cc: NetApp RDAC team <[email protected]> Cc: Zou Ming <[email protected]> Cc: Li Xiaokeng <[email protected]> Cc: Randy Jennings <[email protected]> Cc: Jyoti Rani <[email protected]> Cc: Brian Bunker <[email protected]> Cc: Uday Shankar <[email protected]> Cc: Chaitanya Kulkarni <[email protected]> Cc: Sagi Grimberg <[email protected]> Cc: Keith Busch <[email protected]> Cc: Christoph Hellwig <[email protected]> Cc: Marco Patalano <[email protected]> Cc: Ewan D. Milne <[email protected]> Cc: John Meneghini <[email protected]> Cc: Daniel Wagner <[email protected]> Cc: Daniel Wagner <[email protected]> Cc: Hannes Reinecke <[email protected]> Cc: Martin Wilck <[email protected]> Cc: Benjamin Marzinski <[email protected]> Cc: Christophe Varoqui <[email protected]> Cc: BLOCK-ML <[email protected]> Cc: NVME-ML <[email protected]> Cc: SCSI-ML <[email protected]> Cc: DM_DEVEL-ML <[email protected]> Signed-off-by: Xose Vazquez Perez <[email protected]> --- Maybe these rules should be merged into this new file. ??? 71-nvmf-hpe.rules.in 71-nvmf-netapp.rules.in 71-nvmf-vastdata.rules.in --- .../80-nvmf-storage_arrays.rules.in | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in diff --git a/nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in b/nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in new file mode 100644 index 00000000..ceabba31 --- /dev/null +++ b/nvmf-autoconnect/udev-rules/80-nvmf-storage_arrays.rules.in @@ -0,0 +1,38 @@ +##### Storage arrays + +#### Set iopolicy for NVMe-oF +### iopolicy: numa, round-robin (>=5.1), or queue-depth (>=6.11) + +## Dell EMC +# PowerMax +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="EMC PowerMax" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="EMC PowerMax" +# PowerStore +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="dellemc-powerstore" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="dellemc-powerstore" + +## Huawei +# OceanStor +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="Huawei-XSG1" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="Huawei-XSG1" + +## IBM +# FlashSystem (RamSan) +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="FlashSystem" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="FlashSystem" +# FlashSystem (Storwize/SVC) +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="IBM*214" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="IBM*214" + +## Infinidat +# InfiniBox +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="InfiniBox" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="InfiniBox" + +## Pure +# FlashArray +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="round-robin", ATTR{model}=="Pure Storage FlashArray" +ACTION=="add|change", SUBSYSTEM=="nvme-subsystem", ATTR{subsystype}=="nvm", ATTR{iopolicy}="queue-depth", ATTR{model}=="Pure Storage FlashArray" + + +##### EOF -- 2.50.1
