On Fri, 2026-03-13 at 12:00 +0100, Xose Vazquez Perez wrote: > ACK from the Copyright holder. > > Cc: Martin Wilck <[email protected]> > Cc: Benjamin Marzinski <[email protected]> > Cc: Christophe Varoqui <[email protected]> > Cc: DM_DEVEL-ML <[email protected]> > Signed-off-by: Xose Vazquez Perez <[email protected]> > Signed-off-by: Matthias Rudolph <[email protected]> > --- > libmultipath/prioritizers/hds.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libmultipath/prioritizers/hds.c > b/libmultipath/prioritizers/hds.c > index 212301ea..70eaa8c0 100644 > --- a/libmultipath/prioritizers/hds.c > +++ b/libmultipath/prioritizers/hds.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > /* > * (C) Copyright HDS GmbH 2006. All Rights Reserved. > * > @@ -60,9 +61,6 @@ > * not work under RHEL4 U3 i386 > * Changes 2007-06-27: > * - switched from major:minor argument to device node argument > - * > - * This file is released under the GPL. > - * > */ > > #include <stdio.h>
This represents a license change. The common understanding of "GPL without version", AFAIK, is that the person receiving the code can choose to use it under any version of the GPL, including GPLv1. Strictly speeking, by changing the license to GPL v2.0, we're taking away rights from users. Hitachi Vantara as the successor of HDS is the main copyright holder for this file. While others have contributed to the file, the respective changes are all trivial. So by adding Matthias' S-O-B, you're adding credibility to this change. Anyway, users are free to use and distribute the code from earlier versions of multipath-tools under other versions of the GPL. So: Reviewed-by: Martin Wilck <[email protected]>
