On 04/29/2016 12:06 AM, Sebastian Herbszt wrote:
> Hannes Reinecke wrote:
>> Signed-off-by: Hannes Reinecke <h...@suse.de>
>> ---
>>  libmultipath/hwtable.c | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
> 
> You missed adding it to multipath.conf.defaults.
> 
Yes, but we're about to phase them out anyway.
Cf the recent discussion.

>> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
>> index a4ae053..28ee595 100644
>> --- a/libmultipath/hwtable.c
>> +++ b/libmultipath/hwtable.c
>> @@ -175,6 +175,21 @@ static struct hwentry default_hw[] = {
>>              .prio_name     = PRIO_ALUA,
>>              .prio_args     = NULL,
>>      },
>> +    {
>> +            /* HP MSA 1040/2040 product family */
>> +            .vendor        = "HP",
>> +            .product       = "MSA (1|2)040 SA(N|S)",
>> +            .features      = DEFAULT_FEATURES,
>> +            .hwhandler     = DEFAULT_HWHANDLER,
>> +            .pgpolicy      = GROUP_BY_PRIO,
>> +            .pgfailback    = -FAILBACK_IMMEDIATE,
>> +            .rr_weight     = RR_WEIGHT_NONE,
>> +            .no_path_retry = 18,
>> +            .minio         = 100,
>> +            .checker_name  = TUR,
>> +            .prio_name     = PRIO_ALUA,
>> +            .prio_args     = NULL,
>> +    },
>>  
>>      {
>>              /* HP SVSP */
> 
> Any reason for a separate entry and not merging it with
> "HP MSA2000 product family with new firmware" ?
> 
Yes. MSA2000 are completely different beasts, so I'd like to keep
them separate.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Teamlead Storage & Networking
h...@suse.de                                   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Reply via email to