On Wed, May 18, 2016 at 01:26:34PM -0400, Todd Gill wrote: > > v4: > > removed space in major_version and minor_version keys. Hi Todd,
Few things:
* Please provide path group id from 'pgindex' of struct path.
* Replace key name 'host adapter' with 'host_adapter'.
* Remove output properties as many as you can, only expose
those with clear user case and good definition.
For API, it's easy to add but hard to remove or change.
For example: IMHO, we don't need to expose
hcil, next_check, size, serial right now,
* Performance concern. I am getting bad performance(25 seconds
while previous 'raw format' way only take 1.5 seconds) on 10k
disks. I am still investigating which part slow things down.
Thank you.
Best regards.
--
Gris Ge
signature.asc
Description: PGP signature
-- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
