I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/md/raid5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 8959e6d..33562bf 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -66,7 +66,7 @@ #define ANY_GROUP NUMA_NO_NODE static bool devices_handle_discard_safely = false; -module_param(devices_handle_discard_safely, bool, 0644); +module_param(devices_handle_discard_safely, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(devices_handle_discard_safely, "Set to Y if all devices in each array reliably return zeroes on reads from discarded regions"); static struct workqueue_struct *raid5_wq; -- 2.9.2 -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
