On 03/09/2019 20:58, Mike Snitzer wrote: > On Mon, Aug 19 2019 at 10:17am -0400, > Ard Biesheuvel <[email protected]> wrote: > >> Only the ESSIV IV generation mode used to use cc->cipher so it could >> instantiate the bare cipher used to encrypt the IV. However, this is >> now taken care of by the ESSIV template, and so no users of cc->cipher >> remain. So remove it altogether. >> >> Signed-off-by: Ard Biesheuvel <[email protected]> > > Acked-by: Mike Snitzer <[email protected]> > > Might be wise to bump the dm-crypt target's version number (from > {1, 19, 0} to {1, 20, 0}) at the end of this patch too though...
The function should be exactly the same, dependencies on needed modules are set. In cryptsetup we always report dm target + kernel version, so we know that since version 5.4 it uses crypto API for ESSIV. I think version bump here is really not so important. Just my two cents :) Anyway, thanks everyone. Milan
