On Thu, Aug 13, 2020 at 11:53:14PM -0700, Sagi Grimberg wrote:
> > + switch (nvme_req_disposition(req)) {
> > + case COMPLETE:
> > + nvme_complete_req(req);
>
> nvme_complete_rq calling nvme_complete_req... Maybe call it
> __nvme_complete_rq instead?
That's what I had first, but it felt so strangely out of place next
to the other nvme_*_req calls..
Maybe nvme_complete_rq needs to be renamed - what about nvme_req_done?
> Maybe call nvme_req_disposition again locally here to not carry
> the is_ana_status. But not a biggy..
That means it would have to become non-static in scope, limiting
inlining possibilities, etc.
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
