[dm-devel] [PATCH 4/6] libmultipath: check blist before calling MALLOC in alloc_ble_device func

[Zhiqiang Liu]

In alloc_ble_device func, ble is firstly allocated by calling MALLOC,
and then input blist is checked whether it is valid. If blist is not
valid, ble will be freed without using.

Here, we should check blist firstly.

Signed-off-by: Zhiqiang Liu <liuzhiqian...@huawei.com>
Signed-off-by: lixiaokeng <lixiaok...@huawei.com>
---
 libmultipath/blacklist.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/libmultipath/blacklist.c b/libmultipath/blacklist.c
index db58ccc..bedcc7e 100644
--- a/libmultipath/blacklist.c
+++ b/libmultipath/blacklist.c
@@ -66,12 +66,16 @@ out:

 int alloc_ble_device(vector blist)
 {
-       struct blentry_device * ble = MALLOC(sizeof(struct blentry_device));
+       struct blentry_device *ble;

+       if (!blist)
+               return 1;
+
+       ble = MALLOC(sizeof(struct blentry_device));
        if (!ble)
                return 1;

-       if (!blist || !vector_alloc_slot(blist)) {
+       if (!vector_alloc_slot(blist)) {
                FREE(ble);
                return 1;
        }
-- 
1.8.3.1



--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel