On 2020/8/31 17:55, Martin Wilck wrote:
> Hello Zhiqiang,
>
> On Sat, 2020-08-29 at 11:03 +0800, Zhiqiang Liu wrote:
>> sd_notify_status() is very similar with daemon_status(), except
>> DAEMON_IDLE and DAEMON_RUNNING state. As suggested by Martin,
>> we can create the sd notification string in a dynamic buffer,
>> and treat DAEMON_IDLE and DAEMON_RUNNING cases first. Then,
>> we can use daemon_status_msg[state] for other cases.
>>
>> V2->V3:
>> - set MSG_SIZE to 32 and use safe_sprintf as suggested by Martin.
>>
>> Signed-off-by: Zhiqiang Liu <[email protected]>
>> Signed-off-by: lixiaokeng <[email protected]>
>> ---
>> multipathd/main.c | 34 ++++++++++++----------------------
>> 1 file changed, 12 insertions(+), 22 deletions(-)
>
> Thanks again. I'd like to modify the patch slightly as attached.
> I'm sorry that I didn't mention these minor issues in my previous
> reviews. I'm sending you the fixup patch in order to short-circuit
> the procedure a bit and save both of us some work.
>
> Would this be ok for you?
> If yes, please resubmit this as v4.
>
> Regards,
> Martin
>
Thanks for your suggestion.
I will send the v4 patch as your suggestion.
Regards,
Zhiqiang Liu
--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel
