> Looks mostly good. I agree that we should be checking the results of
> getting the raw data before we try to disassemble it. But, there's not
> really any point to calling continue as the last operation of a loop.
> Perhaps
> 
> if (update_multipath_table(mpp, pathvec, DI_CHECKER) == DMP_OK)
>       update_multipath_status(mpp);
> 
> makes more sense.
> 
Hi Ben,
  Thanks for your review. I will change it in patch v2.

-Lixiaokeng


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Reply via email to