On Thu 26-11-20 14:04:09, Christoph Hellwig wrote:
> Move the start_sect field to struct block_device in preparation
> of killing struct hd_struct.
> 
> Signed-off-by: Christoph Hellwig <h...@lst.de>

Looks good, just one nit below. Feel free to add:

Reviewed-by: Jan Kara <j...@suse.cz>

> diff --git a/block/partitions/core.c b/block/partitions/core.c
> index 8924e1ea8b2ad6..485777cea26bfa 100644
> --- a/block/partitions/core.c
> +++ b/block/partitions/core.c
> @@ -192,7 +192,7 @@ static ssize_t part_start_show(struct device *dev,
>  {
>       struct hd_struct *p = dev_to_part(dev);
>  
> -     return sprintf(buf, "%llu\n",(unsigned long long)p->start_sect);
> +     return sprintf(buf, "%llu\n",(unsigned long 
> long)p->bdev->bd_start_sect);

The long long conversion is pointless here, right?

                                                                        Honza
-- 
Jan Kara <j...@suse.com>
SUSE Labs, CR

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Reply via email to