@@ -134,6 +134,12 @@ static int hwpoison_filter_dev(struct page *p)
        if (PageSlab(p))
                return -EINVAL;
+ if (pfn_valid(page_to_pfn(p))) {
+               if (is_device_fsdax_page(p))
+                       return 0;
+       } else
+               return -EINVAL;
+

Just curious, what is the rational for preventing dax pages from
participating in hwpoison_filter test?

+int mf_dax_kill_procs(struct address_space *mapping, pgoff_t index, int flags)
+{
+       LIST_HEAD(to_kill);
+       /* load the pfn of the dax mapping file */
+       unsigned long pfn = dax_load_pfn(mapping, index);
+
+       /* the failure pfn may not actually be mmapped, so no need to
+        * unmap and kill procs */
+       if (!pfn)
+               return 0;

what if a process has mapped the file but never faulted in, but did ask
for early signal, will it be excluded due to lack of the 'pfn' association?

thanks,
-jane

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Reply via email to