From: Luis Chamberlain <mcg...@kernel.org>

Today dm-zoned relies on the assumption that you have a zone size
with a power of 2. Even though the block layer today enforces this
requirement, these devices do exist and so provide a stop-gap measure
to ensure these devices cannot be used by mistake

Reviewed-by: Hannes Reinecke <h...@suse.de>
Signed-off-by: Luis Chamberlain <mcg...@kernel.org>
Signed-off-by: Pankaj Raghav <p.rag...@samsung.com>
---
 drivers/md/dm-zoned-target.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
index 0ec5d8b9b..ad4228db5 100644
--- a/drivers/md/dm-zoned-target.c
+++ b/drivers/md/dm-zoned-target.c
@@ -792,6 +792,10 @@ static int dmz_fixup_devices(struct dm_target *ti)
                                return -EINVAL;
                        }
                        zone_nr_sectors = blk_queue_zone_sectors(q);
+                       if (!is_power_of_2(zone_nr_sectors)) {
+                               ti->error = "Zone size not power of 2";
+                               return -EINVAL;
+                       }
                        zoned_dev->zone_nr_sectors = zone_nr_sectors;
                        zoned_dev->nr_zones =
                                blkdev_nr_zones(zoned_dev->bdev->bd_disk);
@@ -806,6 +810,10 @@ static int dmz_fixup_devices(struct dm_target *ti)
                q = bdev_get_queue(zoned_dev->bdev);
                zoned_dev->zone_nr_sectors = blk_queue_zone_sectors(q);
                zoned_dev->nr_zones = blkdev_nr_zones(zoned_dev->bdev->bd_disk);
+               if (!is_power_of_2(zoned_dev->zone_nr_sectors)) {
+                       ti->error = "Zone size not power of 2";
+                       return -EINVAL;
+               }
        }
 
        if (reg_dev) {
-- 
2.25.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Reply via email to