This fixes the following issues with the reservation status structs:

1. resv10 is bytes 23:10 so it should be 14 bytes.
2. regctl_ds only supports 64 bit host IDs.

These are not currently used, but will be in this patchset which adds
support for the reservation report command.

Signed-off-by: Mike Christie <michael.chris...@oracle.com>
---
 include/linux/nvme.h | 33 +++++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)

diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index 050d7d0cd81b..3ab141d982d1 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -757,20 +757,37 @@ enum {
        NVME_LBART_ATTRIB_HIDE  = 1 << 1,
 };
 
+struct nvme_registered_ctrl {
+       __le16  cntlid;
+       __u8    rcsts;
+       __u8    rsvd3[5];
+       __le64  hostid;
+       __le64  rkey;
+};
+
+struct nvme_registered_ctrl_ext {
+       __le16  cntlid;
+       __u8    rcsts;
+       __u8    rsvd3[5];
+       __le64  rkey;
+       __u8    hostid[16];
+       __u8    rsvd32[32];
+};
+
 struct nvme_reservation_status {
        __le32  gen;
        __u8    rtype;
        __u8    regctl[2];
        __u8    resv5[2];
        __u8    ptpls;
-       __u8    resv10[13];
-       struct {
-               __le16  cntlid;
-               __u8    rcsts;
-               __u8    resv3[5];
-               __le64  hostid;
-               __le64  rkey;
-       } regctl_ds[];
+       __u8    resv10[14];
+       union {
+               struct {
+                       __u8    rsvd24[40];
+                       struct nvme_registered_ctrl_ext regctl_eds[0];
+               };
+               struct nvme_registered_ctrl regctl_ds[0];
+       };
 };
 
 enum nvme_async_event_type {
-- 
2.25.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel

Reply via email to