On Thu, 3 Nov 2022, Keith Busch wrote:
> On Thu, Nov 03, 2022 at 12:33:19PM -0400, Mikulas Patocka wrote:
> > Hi
> >
> > The patchset seems OK - but dm-integrity also has a limitation that the
> > bio vectors must be aligned on logical block size.
> >
> > dm-writecache and dm-verity seem to handle unaligned bioset, but you
> > should check them anyway.
> >
> > I'm not sure about dm-log-writes.
>
> Yeah, dm-integrity definitly needs it too. This is easy enough to use
> the same io_hint that I added for dm-crypt.
>
> dm-log-writes is doing some weird things with writes that I don't think
> would work with some low level drivers without the same alignment
> constraint.
>
> The other two appear to handle this fine, but I'll run everything
> through some focused test cases to be sure.
>
> In the meantime, do you want to see the remaining mappers fixed in a v2,
> or are you okay if they follow after this series?
I don't care if you make a separate patch or fold it into an existing
patch.
Mikulas
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
