[dm-devel] [PATCH] dm/zone: Use the bitmap API to allocate bitmaps

[Christophe JAILLET]

Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
---
 drivers/md/dm-zone.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c
index 4b82b7798ce4..16776ad3794b 100644
--- a/drivers/md/dm-zone.c
+++ b/drivers/md/dm-zone.c
@@ -140,9 +140,9 @@ bool dm_is_zone_write(struct mapped_device *md, struct bio 
*bio)
 void dm_cleanup_zoned_dev(struct mapped_device *md)
 {
        if (md->disk) {
-               kfree(md->disk->conv_zones_bitmap);
+               bitmap_free(md->disk->conv_zones_bitmap);
                md->disk->conv_zones_bitmap = NULL;
-               kfree(md->disk->seq_zones_wlock);
+               bitmap_free(md->disk->seq_zones_wlock);
                md->disk->seq_zones_wlock = NULL;
        }
 
@@ -182,9 +182,8 @@ static int dm_zone_revalidate_cb(struct blk_zone *zone, 
unsigned int idx,
        switch (zone->type) {
        case BLK_ZONE_TYPE_CONVENTIONAL:
                if (!disk->conv_zones_bitmap) {
-                       disk->conv_zones_bitmap =
-                               kcalloc(BITS_TO_LONGS(disk->nr_zones),
-                                       sizeof(unsigned long), GFP_NOIO);
+                       disk->conv_zones_bitmap = bitmap_zalloc(disk->nr_zones,
+                                                               GFP_NOIO);
                        if (!disk->conv_zones_bitmap)
                                return -ENOMEM;
                }
@@ -193,9 +192,8 @@ static int dm_zone_revalidate_cb(struct blk_zone *zone, 
unsigned int idx,
        case BLK_ZONE_TYPE_SEQWRITE_REQ:
        case BLK_ZONE_TYPE_SEQWRITE_PREF:
                if (!disk->seq_zones_wlock) {
-                       disk->seq_zones_wlock =
-                               kcalloc(BITS_TO_LONGS(disk->nr_zones),
-                                       sizeof(unsigned long), GFP_NOIO);
+                       disk->seq_zones_wlock = bitmap_zalloc(disk->nr_zones,
+                                                             GFP_NOIO);
                        if (!disk->seq_zones_wlock)
                                return -ENOMEM;
                }
-- 
2.34.1

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel