On Fri, Apr 08, 2022 at 05:55:44PM +0300, Серж ИвановЪ wrote: > пт, 8 апр. 2022 г. в 17:46, Geert Stappers <stapp...@stappers.nl>: > > On Fri, Apr 08, 2022 at 04:34:11PM +0300, Серж ИвановЪ wrote: > > > I am talking about this part of code in src/dhcp.c > > > ``` > > > struct ping_result *do_icmp_ping(time_t now, struct in_addr addr, > > unsigned > > > int h > > > { > > > static struct ping_result dummy; > > > struct ping_result *r, *victim = NULL; > > > int count, max = (int)(0.6 * (((float)PING_CACHE_TIME)/ > > > ((float)PING_WAIT))); > > > ``` > > > > > > 0.6 should be configurable via compile-time constants, not hard-coded > > > > That should be expressed as a patch. > > > no problem, will do,
Okay, > if it is acceptable to merge it, just do it that is the way to find out if an acceptable patch was submitted > please confirm, Here you go > thanks Yeah, right Groeten Geert Stappers -- Silence is hard to parse _______________________________________________ Dnsmasq-discuss mailing list Dnsmasq-discuss@lists.thekelleys.org.uk https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss