Hi Tony, Thanks for your feedback, appreciated!
On 14-10-2020 20:15, Tony Finch wrote: > A few questions and suggestions: > > Section 3, algorithm step 5: what is a "hidden QTYPE"? The QTYPE in the incoming query. We made the text more consistent and now always use "original QTYPE". > > Also step 5, a NOERROR answer can be positive or negative, so I think it > should be made clear that this is about a non-NXDOMAIN negative cache > entry. (RFC 2308 calls these "NODATA".) NOERROR can indeed be positive and negative, which is intentional. Also when you have a positive cache result in this step you know that there is no delegation at this level and therefore can add an extra label. I'm ok with making it more clear by explicitly saying that it can be both positive and negative. > > Step 6, what is the "minimised QTYPE"? The term is defined by implication > in section 2, but a reader can't find the definition by searching for the > term. The QTYPE selected by the resolver to do QNAME minimisation. We now changed it to "selected QTYPE" to hopefully make it easier to understand. > > Step 6b, again NOERROR can be positive or negative. I think either this > needs to be more specific, or it should explicitly say it covers both > cases. Both cases indeed. Made that more explicit in the text. > > Step 6c, CHILD might not be the full original QNAME at this point, so it's > only correct to stop on NXDOMAIN here if the resolver is doing RFC 8020 > strict NXDOMAIN. Agree. And without RFC8020 support you should go back to step 3. Added to the text. > > Editorial suggestion: the wall of text in section 2 could do with some > subheadings or bullet points. It would be helpful to make a more clear > separation between rationale/discussion and normative text. I don't have a strong opinion on separating between rationale and normative text. Adding subheadings is a good suggestion. > > I'm not a fan of the term "aggressive" since it sounds unpleasantly > fighty. And I'm not sure how it helps a reader to understand this draft: > AIUI angry vs friendly is supposed to be about the QTYPE used for > truncated query names; the algorithm in section 3 does not depend on this > choice, so I don't know why it is specifically the nasty algorithm. And > section 2 seems to imply the existence of a nice algorithm but there isn't > a specification of it. And why is the choice of QTYPE emotional, but the > number of labels to add is not? This is a leftover from an older version. There now is only one way to do QNAME minimisation, so no need to name it. We removed the "aggressive" references. > > Both section 5 and section 6 seem to be about performance, the problems > and possible benefits, but only the possible benefits count as performance > considerations. I think the question of how many labels to add on each > iteration should be a core part of QNAME minimization, described in > section 2. I'm ok with moving the text from section 5 to a subsection of 2. Thanks! -- Ralph _______________________________________________ DNSOP mailing list DNSOP@ietf.org https://www.ietf.org/mailman/listinfo/dnsop
