On Mon, 19 Jul 2010, Michael Lang wrote:
and found that the module tsig.py was creating the hashes with the buildin
function of the md5/sha module
instead of a "kind" of the HashlibWrapper when using hashlib and python 2.5+
HashlibWrapper isn't necessary here, but rather:
except ImportError:
import md5, sha
hashes[dns.name.from_text('HMAC-MD5.SIG-ALG.REG.INT')] = md5
hashes[dns.name.from_text('hmac-sha1')] = sha
is sufficient. md5 and sha have the "new" function, whereas md5.md5 and
sha.sha do not. (It looks like this got modified after I submitted the
patch to support additional TSIG types.)
after fixing this i identified two additional bugs in update.py and
resolver.py when calling "use_tsig", where the method
expect as third (unnamed) argument the fudge and not the keyalgorithom.
Oops, you appear to be correct here.
(Just to clarify, I submitted the patch to add new TSIG types, but I don't
maintain dnspython.)
--
Kevin Chen
_______________________________________________
dnspython-bugs mailing list
[email protected]
http://howl.play-bow.org/mailman/listinfo.cgi/dnspython-bugs
