Issac Goldstand wrote:
Stas,
  I feel like a complete bum pointing out a "potential problem" when I'm
perfectly aware that I don't have the time (or the hardware at the moment)
to look at it at all but....
Remember that Debian Sarge is scheduled for release in ~3 weeks.  Probably a
good idea to make sure the patch doesn't mess anything up with the default
releases there...

  Issac
  *cowers against the slam of criticism he know's he's got coming his way*

Sorry, Issac, I don't understand what seems to be the problem. Please explain.

----- Original Message ----- From: "Stas Bekman" <[EMAIL PROTECTED]>
To: "Jason Woodward" <[EMAIL PROTECTED]>
Cc: <[email protected]>
Sent: Monday, August 23, 2004 8:06 AM
Subject: Re: debian stable 5.6.1 fix




Jason Woodward wrote:

Building current cvs for Apache 2.0.50 on Debian GNU/Linux stable, perl

5.6.1.

The attached patch fixes a sv_copypv missing symbol error when starting

apache with mod_perl

mod_perl-1.99_15 and newer.

Thanks Jason for the spot and the patch.

After testing is completed I'll apply the following patch (this is sort of
ppport.h, so no code needs to be changed).

I'll probably release 1.99_16 shortly, as this will be a problem for any
5.6.x users.

Index: src/modules/perl/modperl_perl_includes.h
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_perl_includes.h,v
retrieving revision 1.19
diff -u -r1.19 modperl_perl_includes.h
--- src/modules/perl/modperl_perl_includes.h 4 Mar 2004 06:01:07 -0000

1.19

+++ src/modules/perl/modperl_perl_includes.h 23 Aug 2004 05:00:27 -0000
@@ -112,4 +112,21 @@
 #   define environ (*_NSGetEnviron())
 #endif

+/* sv_copypv was added in perl 5.7.3 */
+#ifndef sv_copypv
+#  define sv_copypv(dsv, ssv)     \
+    STMT_START {                  \
+        STRLEN len;               \
+        char *s;                  \
+        s = SvPV(ssv, len);       \
+        sv_setpvn(dsv, s, len);   \
+        if (SvUTF8(ssv)) {        \
+            SvUTF8_on(dsv);       \
+        }                         \
+        else {                    \
+            SvUTF8_off(dsv);      \
+        }                         \
+    } STMT_END
+#endif
+
 #endif /* MODPERL_PERL_INCLUDES_H */

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to