Thx a lot! What is the best channel for contributor? IRC? This is user support as i think
С Уважением, Мельчук Артем. 2017-11-04 20:32 GMT+03:00 Marco Pivetta <ocram...@gmail.com>: > Let us know if we can help out in getting started - contributing to OSS > from a simple patch is the best way to start :-) > > Marco Pivetta > > http://twitter.com/Ocramius > > http://ocramius.github.com/ > > On Sat, Nov 4, 2017 at 6:30 PM, Артем Мельчук <artyom.melc...@gmail.com> > wrote: > >> Hi, Macrco! >> I understood workflow. After next week will try to make this. It's ok? >> I am not very familiar with git ( prefer svn) and phpunit(prefer clear >> code and architecture), but it's good case for practice in this area. >> >> >> С Уважением, Мельчук Артем. >> >> 2017-11-04 19:38 GMT+03:00 Marco Pivetta <ocram...@gmail.com>: >> >>> Hey Артем, >>> >>> A test would be an addition to https://github.com/doctrine/do >>> ctrine2/blob/a82f6c5725cb31348eae0b4414e8992b1400ba30/tests/ >>> Doctrine/Tests/ORM/Mapping/XmlMappingDriverTest.php >>> >>> You have to write a mapping with a `custom-id-generator` that breaks on >>> the current version of the ORM, and that is fixed once you apply your patch >>> to the XSD :-) >>> >>> Marco Pivetta >>> >>> http://twitter.com/Ocramius >>> >>> http://ocramius.github.com/ >>> >>> On Sat, Nov 4, 2017 at 3:51 PM, Артем Мельчук <artyom.melc...@gmail.com> >>> wrote: >>> >>>> it's here: >>>> <xs:complexType name="custom-id-generator"> >>>> <xs:sequence> >>>> <xs:any minOccurs="0" maxOccurs="unbounded" namespace="##other"/> >>>> </xs:sequence> >>>> <xs:attribute name="class" type="xs:NMTOKEN" use="required" /> >>>> </xs:complexType> >>>> >>>> so we just need to change it's to xs:string >>>> >>>> Patch is you mean create new version of doctrine-mapping.xsd and make >>>> diff for them and attach it's here? >>>> What kind of test you need? >>>> >>>> >>>> i made >>>> >>>> >>>> *diff doctrine-mapping-old.xsd doctrine-mapping.xsd > >>>> doctrine-mapping.xsd.patch* >>>> my xml is now valid against corrected xsd. files and patch in >>>> attachment. >>>> >>>> >>>> >>>> >>>> С Уважением, Мельчук Артем. >>>> >>>> 2017-11-04 16:19 GMT+03:00 Marco Pivetta <ocram...@gmail.com>: >>>> >>>>> Send a patch with a test 👍 >>>>> >>>>> On 4 Nov 2017 13:48, "MetaAbstract" <artyom.melc...@gmail.com> wrote: >>>>> >>>>>> Hi, >>>>>> I define custom id generator and can't define class for custom id >>>>>> generator because class is nmtoken type not string. XSD checker give >>>>>> error >>>>>> for class name. >>>>>> >>>>>> <orm:id name="DUUID" type="string" length="33"> >>>>>> <orm:generator strategy="CUSTOM"></orm:generator> >>>>>> <orm:custom-id-generator class="MetaAbstract\Documents\ >>>>>> Utils\DUUID"></orm:custom-id-generator> >>>>>> </orm:id> >>>>>> I need to correct xsd or i am don't understand something? >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "doctrine-user" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to doctrine-user+unsubscr...@googlegroups.com. >>>>>> To post to this group, send email to doctrine-user@googlegroups.com. >>>>>> Visit this group at https://groups.google.com/group/doctrine-user. >>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to a topic in the >>>>> Google Groups "doctrine-user" group. >>>>> To unsubscribe from this topic, visit https://groups.google.com/d/to >>>>> pic/doctrine-user/q9aHfy5l30M/unsubscribe. >>>>> To unsubscribe from this group and all its topics, send an email to >>>>> doctrine-user+unsubscr...@googlegroups.com. >>>>> To post to this group, send email to doctrine-user@googlegroups.com. >>>>> Visit this group at https://groups.google.com/group/doctrine-user. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "doctrine-user" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to doctrine-user+unsubscr...@googlegroups.com. >>>> To post to this group, send email to doctrine-user@googlegroups.com. >>>> Visit this group at https://groups.google.com/group/doctrine-user. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "doctrine-user" group. >>> To unsubscribe from this topic, visit https://groups.google.com/d/to >>> pic/doctrine-user/q9aHfy5l30M/unsubscribe. >>> To unsubscribe from this group and all its topics, send an email to >>> doctrine-user+unsubscr...@googlegroups.com. >>> To post to this group, send email to doctrine-user@googlegroups.com. >>> Visit this group at https://groups.google.com/group/doctrine-user. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "doctrine-user" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to doctrine-user+unsubscr...@googlegroups.com. >> To post to this group, send email to doctrine-user@googlegroups.com. >> Visit this group at https://groups.google.com/group/doctrine-user. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to a topic in the > Google Groups "doctrine-user" group. > To unsubscribe from this topic, visit https://groups.google.com/d/ > topic/doctrine-user/q9aHfy5l30M/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > doctrine-user+unsubscr...@googlegroups.com. > To post to this group, send email to doctrine-user@googlegroups.com. > Visit this group at https://groups.google.com/group/doctrine-user. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "doctrine-user" group. To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+unsubscr...@googlegroups.com. To post to this group, send email to doctrine-user@googlegroups.com. Visit this group at https://groups.google.com/group/doctrine-user. For more options, visit https://groups.google.com/d/optout.
