On Fri, Oct 21, 2011 at 11:52:07AM +0200, Johannes Ring wrote: > On Fri, Oct 21, 2011 at 11:43 AM, Anders Logg <l...@simula.no> wrote: > > On Fri, Oct 21, 2011 at 11:27:57AM +0200, Anders Logg wrote: > >> On Fri, Oct 21, 2011 at 10:41:57AM +0200, Martin Sandve Alnæs wrote: > >> > If this cannot be fixed quickly, can you please revert the commit that > >> > caused it? > >> > > >> > In general, quickly fixing or reverting when stuff is broken is the > >> > only way we can keep a consistently green buildbot. Having the > >> > buildbots in a red state over time hinders further development in > >> > maintrunk and/or hides problems caused by additional commits. This > >> > time the build problem did hide test breakage caused by both me and > >> > Anders, and the fixes were then much delayed. I think it is worth > >> > considering requiring quick revert of all developers (I know I've > >> > sinned there myself). > >> > >> Sorry for breaking the buildbot, but I've had trouble with my own > >> personal buildbot not running at all so I couldn't test there first. > >> (And the thing that currently breaks works fine here with me.) > >> > >> I'm not sure reverting now is a good idea since it is a big change > >> that is important for the book (cleanup of the Krylov methods and > >> preconditioner options). > >> > >> It looks to me like something needs to be updated or rebuilt on the > >> buildbot. The unit test that fails on the buildbot (quadrature on cut > >> cells using CGAL) works fine here, and also for Andre. Maybe the > >> buildbot just needs a new installation of CGAL and/or boost? > > > > The error message seems to indicate a problem with boost::assign in > > combination with CGAL. Maybe somehow the inclusion of > > > > boost/assign/list_of.hpp > > > > in uBLASFactory.h and MTL4Factory.h propagated to the unit test and > > that breaks with CGAL. > > > > I've worked around the inclusion of this header file now (only > > included in .cpp files). Can those of you for whom this breaks try > > again? > > I will try but I get this now when building DOLFIN: > > [ 1%] Building CXX object > dolfin/CMakeFiles/dolfin.dir/la/DefaultFactory.cpp.o > In file included from > /home/johannr/src/bzr/dolfin/dolfin/la/DefaultFactory.cpp:23: > /home/johannr/src/bzr/dolfin/dolfin/la/uBLASFactory.h: In member > function ‘std::vector<std::pair<std::basic_string<char, > std::char_traits<char>, std::allocator<char> >, > std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::allocator<std::pair<std::basic_string<char, > std::char_traits<char>, std::allocator<char> >, > std::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > > dolfin::uBLASFactory<T>::lu_solver_methods() const’: > /home/johannr/src/bzr/dolfin/dolfin/la/uBLASFactory.h:81: error: > expected ‘;’ before ‘methods’ > make[2]: *** [dolfin/CMakeFiles/dolfin.dir/la/DefaultFactory.cpp.o] Error 1 > make[1]: *** [dolfin/CMakeFiles/dolfin.dir/all] Error 2 > make: *** [all] Error 2
Pull again. I discovered this 30 seconds after I pushed and then pushed the missing byte ';'. -- Anders _______________________________________________ Mailing list: https://launchpad.net/~dolfin Post to : dolfin@lists.launchpad.net Unsubscribe : https://launchpad.net/~dolfin More help : https://help.launchpad.net/ListHelp
