It seems what we did was not enough. Some php instalattion does not provide the feature AND does not allow code to declare it. A very not common setup (probably need to hack php to have this) but may be result of security php addon.
Don't want to take risk, so I included the patch. Changing code into ext lib is not a thing i like but knowing some users can't use dolibarr just because of one code line is not something pleasant... 2014-07-31 20:58 GMT+02:00 Frédéric FRANCE <[email protected]>: > Hello > Here is the french discussion why i proposed that: > > http://www.dolibarr.fr/forum/3-installation/50977-probleme-d-installation-chez-un-hebergeur-gratuit > > On some host checking getmypid() say's function doses'nt exist but it's > impossible to redeclare. > And just because of this function, you loose a potential user > > Fred > > Le 31/07/2014 20:26, Marcos García a écrit : > > Hi all: > > I've noticed a PR made by frederic ( > https://github.com/Dolibarr/dolibarr/pull/1792) was accepted, and so > getmypid was renamed to dol_getmypid. > > My question is: why was that made? The check if function does not exists > before recreating the function getmypid wasn't enough? > > I brought the discussion to the ML because I think it is a better place > to discuss this things. > > Regards, > > > *Marcos García* > > [email protected] > > > > _______________________________________________ > Dolibarr-dev mailing > [email protected]https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > > > _______________________________________________ > Dolibarr-dev mailing list > [email protected] > https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > -- Laurent Destailleur (alias Eldy) ------------------------------------------------------------------------------------ Social networks of my OpenSource projects: Dolibarr Google+: https://plus.google.com/+DolibarrOrg/ Dolibarr Facebook: https://www.facebook.com/dolibarr Dolibarr Twitter: http://www.twitter.com/dolibarr AWStats Google+: https://plus.google.com/+AWStatsOrgPoject/ AWStats Facebook: https://www.facebook.com/awstats.org AWStats Twitter: http://www.twitter.com/awstats_project
_______________________________________________ Dolibarr-dev mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
