Yes, We must include tests dedicated for pgsql. A first step is to test an install process on pgsql.
Easier to do, another thing we can add into the travis test is a script that will make a grep and return an error if a forbidden key is found into htdocs/install/mysql/*/*.sql files. So an error will be reported when a PR not compatible with pgsql is done. 2015-11-06 11:03 GMT+01:00 Florian HENRY <[email protected]>: > Hello All, > > During solving an issue > https://github.com/Dolibarr/dolibarr/issues/3912 > I've meet some bad SQL practice into core sql migration files. > > As dolibarr is PgSql comptabile we must keep in mind some SQL rules : > for exemple > ALTER TABLE llx_societe_rib ADD COLUMN frstrecur varchar(16) > *default* 'FRST' *after* rum; > will not work in pgsql (due to our SQL wrapper > /core/db/pgsql.class.php) > ALTER TABLE llx_societe_rib ADD COLUMN frstrecur varchar(16) > *DEFAULT* 'FRST' *AFTER* rum; > is the good syntax > > a PR is on is way with this fix on 3.8 branch > https://github.com/Dolibarr/dolibarr/pull/3911 > > Should we include into test unit pgsql migration script ? > > Regards > > -- > Florian Henry+33 6 03 76 48 > [email protected]http://www.open-concept.pro > Twitter : @_Open_Concept_ > Google+ : https://www.google.com/+Open-conceptPro > > > _______________________________________________ > Dolibarr-dev mailing list > [email protected] > https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > -- EMail: [email protected] Web: http://www.destailleur.fr ------------------------------------------------------------------------------------ Google+: https://plus.google.com/+LaurentDestailleur/ Facebook: https://www.facebook.com/Destailleur.Laurent Twitter: http://www.twitter.com/eldy10 ------------------------------------------------------------------------------------ * Dolibarr (Project leader): http://www.dolibarr.org (make a donation for Dolibarr project via Paypal: [email protected]) * AWStats (Author) : http://awstats.sourceforge.net (make a donation for AWStats project via Paypal: [email protected]) * AWBot (Author) : http://awbot.sourceforge.net * CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
_______________________________________________ Dolibarr-dev mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
