You're right. I pushed a fix to have php unit working in both cases. 2016-02-02 11:36 GMT+01:00 Florian HENRY <[email protected]>:
> Ok, but still, anywhere in core dolibarr we have code to deal with tax > like -19:-15:-9 > > Dataset coming from mysqldump_dolibarr_3.5.0.sql migrate to 3.8 is not the > same as dataset coming from mysqldump_dolibarr_3.8.0.sql. > > It can be confusing for local phpunit test before submit PR to github. > > Regards > > Florian Henry+33 6 03 76 48 > [email protected]http://www.open-concept.pro > Twitter : @_Open_Concept_ > Google+ : https://www.google.com/+Open-conceptPro > > Le 31/01/2016 19:41, Laurent Destailleur (aka Eldy) a écrit : > > Yes, having x:y:z into localtax is a feature used for spanish companies. > The datadump is not broken it is just not the datadump that match the > phpunit. The phpunit is done acoording to data define into the dump of 3.5 > version with migration done from 3.5 to 3.8. > Having phpunit tests that does not depends on database data/setup is very > difficult. We must just know it works with the dump of 3.5 migrated > > 2016-01-30 18:06 GMT+01:00 Florian HENRY <[email protected]>: > >> Hello all, >> >> The current dev branch failed on travis cause of >> >> 1) FunctionsLibTest::testGetDefaultLocalTax >> Failed asserting that '-19:-15:-9' matches expected -19. >> >> >> /home/bobby/Eclipse/workspace/dolibarr/test/phpunit/FunctionsLibTest.php:858 >> >> >> When I dig on dev/initdata/mysqldump_dolibarr_3.8.0.sql, I see >> -19:-15:-9 into localtax_2 lot's of time. >> >> My question is data_dump broken or it is a feature to declare multiple >> tva level, but if it is the case it's still ongoing dev. I can't find >> anywhere a piece of code to deal with this VAT rate parate by ":" .In >> htdcos/admin/dict.php it try to do a price('-19:-15:-9')=>0. >> >> Shall we avoid to merge PR that cause travis crash even in dev branch ? >> >> Regards >> >> -- >> Florian Henry >> +33 6 03 76 48 07 >> [email protected] >> http://www.open-concept.pro >> Twitter : @_Open_Concept_ >> Google+ : https://www.google.com/+Open-conceptPro >> >> >> >> _______________________________________________ >> Dolibarr-dev mailing list >> [email protected] >> https://lists.nongnu.org/mailman/listinfo/dolibarr-dev >> > > > > -- > EMail: [email protected] > Web: http://www.destailleur.fr > > ------------------------------------------------------------------------------------ > Google+: <https://plus.google.com/+LaurentDestailleur/> > https://plus.google.com/+LaurentDestailleur/ > Facebook: <https://www.facebook.com/Destailleur.Laurent> > https://www.facebook.com/Destailleur.Laurent > Twitter: <http://www.twitter.com/eldy10>http://www.twitter.com/eldy10 > > ------------------------------------------------------------------------------------ > * Dolibarr (Project leader): <http://www.dolibarr.org> > http://www.dolibarr.org (make a donation for Dolibarr project via Paypal: > <[email protected]>[email protected]) > * AWStats (Author) : http://awstats.sourceforge.net (make a donation for > AWStats project via Paypal: <[email protected]>[email protected] > ) > * AWBot (Author) : http://awbot.sourceforge.net > * CVSChangeLogBuilder (Author) : <http://cvschangelogb.sourceforge.net> > http://cvschangelogb.sourceforge.net > > > > > _______________________________________________ > Dolibarr-dev mailing > [email protected]https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > > > _______________________________________________ > Dolibarr-dev mailing list > [email protected] > https://lists.nongnu.org/mailman/listinfo/dolibarr-dev > > -- EMail: [email protected] Web: http://www.destailleur.fr ------------------------------------------------------------------------------------ Google+: https://plus.google.com/+LaurentDestailleur/ Facebook: https://www.facebook.com/Destailleur.Laurent Twitter: http://www.twitter.com/eldy10 ------------------------------------------------------------------------------------ * Dolibarr (Project leader): http://www.dolibarr.org (make a donation for Dolibarr project via Paypal: [email protected]) * AWStats (Author) : http://awstats.sourceforge.net (make a donation for AWStats project via Paypal: [email protected]) * AWBot (Author) : http://awbot.sourceforge.net * CVSChangeLogBuilder (Author) : http://cvschangelogb.sourceforge.net
_______________________________________________ Dolibarr-dev mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/dolibarr-dev
