On Wed, 2007-05-09 at 11:40 +0300, Timo Sirainen wrote:
> On Wed, 2007-05-09 at 10:05 +0200, Steffen Kaiser wrote:
>
> > - --- src/deliver/mail-send.c (revision 47)
> > +++ src/deliver/mail-send.c (working copy)
> > @@ -42,7 +42,7 @@
> > i_info("msgid=%s: Return-Path missing, rejection reason: %s",
> > orig_msgid == NULL ? "" : str_sanitize(orig_msgid, 80),
> > str_sanitize(reason, 512));
> > - - return 0;
> > + return EX_TEMPFAIL;
> > }
>
> I actually did the exact opposite change a few months ago :)
>
> 2007-03-26 00:24 Timo Sirainen <[EMAIL PROTECTED]>
>
> * src/deliver/mail-send.c: If we couldn't send a bounce because of
> a missing Return-Path header, just return success instead of
> failing with EX_TEMPFAIL.
>
> I'm not sure why I changed that. I think this is a problem only if the
> SMTP server is misconfigured not to add the Return-Path header? In that
> case I'll change the above i_info() to i_error() also..Oh, right, return_address = NULL also if the address isn't valid. In those cases I think it should return 0, because there just isn't anything to be done. So EX_TEMPFAIL should only be returned if the whole Return-Path: is missing I think.
signature.asc
Description: This is a digitally signed message part
