On 2017-08-24 21:39, David Binderman wrote:
Hello there,dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:130]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ((ret = doveadm_print_istream(input) < 0)) Maybe better code if ((ret = doveadm_print_istream(input)) < 0) Some duplicates: [dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:220]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. [dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:237]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. [dovecot-2.2.32/src/doveadm/doveadm-mail-fetch.c:261]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Regards David Binderman
Thank you, we'll take a look. Aki
