On 28.03.2018 22:14, Odhiambo Washington wrote:
>
>
> On 27 March 2018 at 20:06, <aki.tu...@dovecot.fi
> <mailto:aki.tu...@dovecot.fi>> wrote:
>
>     Hi!
>
>     We are releasing v2.3.1, which mostly consists of bug fixes for
>     2.3.0, and few improvements. This is also available via
>     https://repo.dovecot.org if you want packages. libsodium support
>     didn't get into this build, due to build environment issues, but
>     2.3.2 will contain it.
>
>     * Submission server support improvements and bug fixes
>       - Lots of bug fixes to submission server
>     * API CHANGE: array_idx_modifiable will no longer allocate space
>      - Particularly affects how you should check MODULE_CONTEXT
>     result, or use REQUIRE_MODULE_CONTEXT.
>
>     + mail_attachment_detection_options setting controls when
>       $HasAttachment and $HasNoAttachment keywords are set for mails.
>     + imap: Support fetching body snippets using FETCH (SNIPPET) or
>       (SNIPPET (LAZY=FUZZY))
>     + fs-compress: Automatically detect whether input is compressed or
>     not.
>       Prefix the compression algorithm with "maybe-" to enable the
>       detection, for example: "compress:maybe-gz:6:..."
>     + Added settings to change dovecot.index* files' optimization
>     behavior.
>       See https://wiki2.dovecot.org/IndexFiles#Settings
>     <https://wiki2.dovecot.org/IndexFiles#Settings>
>     + Auth cache can now utilize auth workers to do password hash
>       verification by setting auth_cache_verify_password_with_worker=yes.
>     + Added charset_alias plugin. See
>       https://wiki2.dovecot.org/Plugins/CharsetAlias
>     <https://wiki2.dovecot.org/Plugins/CharsetAlias>
>     + imap_logout_format and pop3_logout_format settings now support
>     all of the generic variables (e.g. %{rip}, %{session}, etc.)
>
>     --
>     Aki Tuomi
>     Dovecot oy
>
>
>
> Making all in lib-charset
> /bin/sh ../../libtool  --tag=CC    --mode=link cc  -std=gnu99 -g -O2
> -fstack-protector-strong -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall
> -W -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith
> -Wchar-subscripts -Wformat=2 -Wbad-function-cast
> -Wno-duplicate-decl-specifier -Wstrict-aliasing=2
> -I/usr/local/include   -no-undefined -Wl,--as-needed -o test-charset
> test-charset.o libcharset.la <http://libcharset.la>
> ../lib-test/libtest.la <http://libtest.la>  ../lib/liblib.la
> <http://liblib.la>
> libtool: link: cc -std=gnu99 -g -O2 -fstack-protector-strong
> -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -W -Wmissing-prototypes
> -Wmissing-declarations -Wpointer-arith -Wchar-subscripts -Wformat=2
> -Wbad-function-cast -Wno-duplicate-decl-specifier -Wstrict-aliasing=2
> -I/usr/local/include -Wl,--as-needed -o test-charset test-charset.o 
> ./.libs/libcharset.a ../lib-test/.libs/libtest.a ../lib/.libs/liblib.a
> ./.libs/libcharset.a(charset-iconv.o): In function
> `iconv_charset_to_utf8_begin':
> /home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:29:
> undefined reference to `libiconv_open'
> ./.libs/libcharset.a(charset-iconv.o): In function
> `iconv_charset_to_utf8_end':
> /home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:44:
> undefined reference to `libiconv_close'
> ./.libs/libcharset.a(charset-iconv.o): In function
> `iconv_charset_to_utf8_reset':
> /home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:51:
> undefined reference to `libiconv'
> ./.libs/libcharset.a(charset-iconv.o): In function `charset_to_utf8_try':
> /home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:74:
> undefined reference to `libiconv'
> cc: error: linker command failed with exit code 1 (use -v to see
> invocation)
> *** Error code 1
>
> Stop.
> make[3]: stopped in
> /usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset
> *** Error code 1
>
> Stop.
> make[2]: stopped in /usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src
> *** Error code 1
>
> Stop.
> make[1]: stopped in /usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1
> *** Error code 1
>
> Stop.
> make: stopped in /usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1
>
> root@waridi:/usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1 # uname -mrs
> *FreeBSD 11.1-STABLE amd64* 
>
>
>
>
>
> -- 
> Best regards,
> Odhiambo WASHINGTON,
> Nairobi,KE
> +254 7 3200 0004/+254 7 2274 3223
> "Oh, the cruft."

Can you try the attached patch?

Aki
>From 6e6437533e30c71f79a0867d50f3b1b707d7a813 Mon Sep 17 00:00:00 2001
From: Aki Tuomi <aki.tu...@dovecot.fi>
Date: Mon, 5 Mar 2018 11:58:57 +0200
Subject: [PATCH] global: Include LTLIBICONV where needed

Fixes problems with FreeBSD 11 build
---
 src/lib-charset/Makefile.am | 2 +-
 src/lib-mail/Makefile.am    | 7 +++++--
 src/lib-storage/Makefile.am | 1 +
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/lib-charset/Makefile.am b/src/lib-charset/Makefile.am
index 5c41f07..9425861 100644
--- a/src/lib-charset/Makefile.am
+++ b/src/lib-charset/Makefile.am
@@ -28,7 +28,7 @@ test_libs = \
 test_deps = $(noinst_LTLIBRARIES) $(test_libs)
 
 test_charset_SOURCES = test-charset.c
-test_charset_LDADD = libcharset.la $(test_libs)
+test_charset_LDADD = libcharset.la $(test_libs) $(LTLIBICONV)
 test_charset_DEPENDENCIES = libcharset.la $(test_deps)
 
 check-local:
diff --git a/src/lib-mail/Makefile.am b/src/lib-mail/Makefile.am
index 8fe43d6..0463d74 100644
--- a/src/lib-mail/Makefile.am
+++ b/src/lib-mail/Makefile.am
@@ -156,6 +156,7 @@ test_message_date_LDADD = $(test_libs)
 test_message_date_DEPENDENCIES = $(test_deps)
 
 test_message_decoder_SOURCES = test-message-decoder.c
+test_message_decoder_LDFLAGS = $(LTLIBICONV)
 test_message_decoder_LDADD = $(test_libs) ../lib-charset/libcharset.la
 test_message_decoder_DEPENDENCIES = $(test_deps) ../lib-charset/libcharset.la
 
@@ -188,12 +189,14 @@ test_message_part_LDADD = $(test_libs)
 test_message_part_DEPENDENCIES = $(test_deps)
 
 test_message_search_SOURCES = test-message-search.c
+test_message_search_LDFLAGS = $(LTLIBICONV)
 test_message_search_LDADD = $(test_libs) ../lib-charset/libcharset.la
 test_message_search_DEPENDENCIES = $(test_deps) ../lib-charset/libcharset.la
 
 test_message_snippet_SOURCES = test-message-snippet.c
-test_message_snippet_LDADD = $(test_message_decoder_LDADD)
-test_message_snippet_DEPENDENCIES = $(test_deps)
+test_message_snippet_LDFLAGS = $(LTLIBICONV)
+test_message_snippet_LDADD = $(test_libs) ../lib-charset/libcharset.la
+test_message_snippet_DEPENDENCIES = $(test_deps) ../lib-charset/libcharset.la
 
 test_mail_html2text_SOURCES = test-mail-html2text.c
 test_mail_html2text_LDADD = $(test_libs)
diff --git a/src/lib-storage/Makefile.am b/src/lib-storage/Makefile.am
index 256ceb7..10c2fef 100644
--- a/src/lib-storage/Makefile.am
+++ b/src/lib-storage/Makefile.am
@@ -142,6 +142,7 @@ test_programs = \
 noinst_PROGRAMS = $(test_programs)
 
 test_libs = \
+	$(LTLIBICONV) \
 	$(top_builddir)/src/lib-test/libtest.la \
 	$(top_builddir)/src/lib/liblib.la
 
-- 
2.1.4

Reply via email to