svn commit: r762690 - in /maven/doxia/doxia/trunk/doxia-core/src: main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java test/java/org/apache/maven/doxia/sink/AbstractXmlSinkTest.java

[ltheussl]

Author: ltheussl
Date: Tue Apr  7 11:11:22 2009
New Revision: 762690

URL: http://svn.apache.org/viewvc?rev=762690&view=rev
Log:
Throw same Exception in end and start tag

Modified:
    
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java
    
maven/doxia/doxia/trunk/doxia-core/src/test/java/org/apache/maven/doxia/sink/AbstractXmlSinkTest.java

Modified: 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java
URL: 
http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java?rev=762690&r1=762689&r2=762690&view=diff
==============================================================================
--- 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java
 (original)
+++ 
maven/doxia/doxia/trunk/doxia-core/src/main/java/org/apache/maven/doxia/sink/AbstractXmlSink.java
 Tue Apr  7 11:11:22 2009
@@ -145,6 +145,11 @@
      */
     protected void writeEndTag( Tag t )
     {
+        if ( t == null )
+        {
+            throw new IllegalArgumentException( "A tag is required" );
+        }
+
         StringBuffer sb = new StringBuffer();
         sb.append( LESS_THAN );
         sb.append( SLASH );

Modified: 
maven/doxia/doxia/trunk/doxia-core/src/test/java/org/apache/maven/doxia/sink/AbstractXmlSinkTest.java
URL: 
http://svn.apache.org/viewvc/maven/doxia/doxia/trunk/doxia-core/src/test/java/org/apache/maven/doxia/sink/AbstractXmlSinkTest.java?rev=762690&r1=762689&r2=762690&view=diff
==============================================================================
--- 
maven/doxia/doxia/trunk/doxia-core/src/test/java/org/apache/maven/doxia/sink/AbstractXmlSinkTest.java
 (original)
+++ 
maven/doxia/doxia/trunk/doxia-core/src/test/java/org/apache/maven/doxia/sink/AbstractXmlSinkTest.java
 Tue Apr  7 11:11:22 2009
@@ -54,6 +54,28 @@
 
         instance.writeSimpleTag( t );
         assertEquals( "<ns:a />", instance.getText() );
+
+        assertEquals( ns, instance.getNameSpace() );
+
+        try
+        {
+            instance.writeStartTag( null );
+            fail( "null tag should fail!" );
+        }
+        catch ( IllegalArgumentException e )
+        {
+            assertNotNull( e );
+        }
+
+        try
+        {
+            instance.writeEndTag( null );
+            fail( "null tag should fail!" );
+        }
+        catch ( IllegalArgumentException e )
+        {
+            assertNotNull( e );
+        }
     }
 
     /**
@@ -128,6 +150,5 @@
         {
             buffer.append( text );
         }
-
     }
 }