Sounds great.
----- Original Message -----
From: "Kim Gr�sman" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Tuesday, July 06, 2004 12:17 PM
Subject: RE: [DQSD-Devel] XP SP2 and window positioning
OK, now I think I see what's going on...
launchmode == 2 is no longer used, and the IE optimization is used even when
launchmode == 1, as per the following commit:
--
Neel Doshi's suggested mods...
I'd like to propose a couple of changes to the tools.js file, however being
a complete javascript neophyte, I'm reluctant to make the changes myself.
Here is the first change I propose:
In tools.js line 60:
if (launchmode == 2 && browserPath.toLowerCase().indexOf("iexplore.exe")
> 0)
Should be
if (launchmode != 0 && browserPath.toLowerCase().indexOf("iexplore.exe")
> 0)
This way, if a user's launchmode equals 1 and their default browser is IE,
then they can retain the benefits from using IE (such as
reuseBrowserWindowMode settings). I would also suggest that line 35 of
tools.js which reads:
var useExternalBrowser = (launchmode > 0);
Should be changed to:
useExternalBrowser = (launchmode > 0);
This way, a search that would benefit from knowing the browser status (i.e.
multi) could look it up.
--
Rev. 1.23, 2002-03-15
I think this is a clean change, and it's been running for well over two
years. I'll ditch launchmode 2 from the preferences.
Cheers,
Kim
> -----Original Message-----
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of
> Glenn Carr
> Sent: den 6 juli 2004 18:06
> To: [EMAIL PROTECTED]
> Subject: Re: [DQSD-Devel] XP SP2 and window positioning
>
> I haven't looked at the code lately, but Monty is correct
> IIRC. "2" was supposed to be the best approach for users
> that switched between default browsers, if one of those
> browsers was IE. Instead of having to specify "0"
> and always use IE, "2" would check to see if IE was the
> default, and if so take the shortcut for creating windows (no
> temp file).
>
> But, it's probably not very often that people are switching
> their default browsers.
>
> ----- Original Message -----
> From: "Monty Scroggins" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Tuesday, July 06, 2004 10:16 AM
> Subject: Re: [DQSD-Devel] XP SP2 and window positioning
>
>
> I believe the launchmode=2 was implemented to make starting a
> search faster
> in IE. I *believe* the URL's are launched in IE directly and the temp
> launch file is not used. Of course if IE isnt your default
> browser, this
> setting does nothing for you...
>
>
> Mont
>
>
> ----- Original Message -----
> From: "Kim Gr�sman" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Tuesday, July 06, 2004 9:01 AM
> Subject: RE: [DQSD-Devel] XP SP2 and window positioning
>
>
> > Monty and all,
> >
> > > > Can we change the default launchmode to 1 instead of 2?
> > > >
> > > > I dont believe 2 works right for some of the IE based
> > > browsers. But
> > > > everything works fine using launchmode = 1.
> > > >
> > > > Do we need a mode 2 at all?
> > >
> > > I don't even know what differs between them... If it doesn't
> > > really work, I say we remove it.
> >
> > I've browsed through the use of launchmode, and nowhere
> does the script
> seem
> > to be checking for launchmode == 2 specifically. It's always just
> > (launchmode > 0), so I don't see the need for a launchmode 2.
> >
> > I think we should remove the comment and set the default to 1.
> >
> > Kim
> >
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
DQSD-Devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dqsd-devel
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
DQSD-Devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dqsd-devel
