Hi Brent,

Thanks for the prompt feedback. I probably won't have time to fix any of
this until next week, so reader contributions are welcome ;)

Cheers,
Kim

> -----Original Message-----
> From: [EMAIL PROTECTED] 
> [mailto:[EMAIL PROTECTED] On Behalf Of 
> Brent Beardsley
> Sent: den 9 december 2004 22:24
> To: [EMAIL PROTECTED]
> Subject: RE: [DQSD-Devel] latest search.nsi
> 
> Hi Kim,
> 
> --- Kim Grdsman <[EMAIL PROTECTED]> wrote:
> 
> > - Guessed wrong color scheme (I'm running Windows Classic 
> but got Blue 
> > - more on this later)
> 
> This is a general problem with the way DQSD current works.  
> We need to put user configuration info in the appdata 
> directory not in the installation directory. 
> So you switch the color scheme to classic and then try to use 
> DQSD as admin and you'll wish it was the blue theme.  I think 
> we should revisit this problem for 4.0 (which is what I think 
> the next version should be with DQSD being hosted in a deskbar).
> 
> > - Uninstall does not remove theme files - it should, right, since 
> > these are no longer user-edited?
> 
> Yes, they're no longer user-edited so probably should be 
> removed in uninstaller.
> 
> > - Should "None" be named "Classic" to map better to the 
> Windows names?
> 
> Probably.
> 
> > - Installer doesn't complain if I'm not an admin, but fails 
> to write 
> > the required registry keys for DQSD (CLSID\{22...}\...)
> 
> We need to check the error code on the registry write.
>  
> > The only possible fix, that I can see, would be to defer the theme 
> > detection until the toolbar starts up, but I don't think it's worth 
> > the extra complexity and work to fix it - not that many 
> people run as 
> > non-admin yet.
> 
> The Windows XP theme checking essentially just checks a 
> couple of registry settings.  Wouldn't be too hard to add to 
> DQSDTools and then add the theme picking code to search.htm 
> to include the proper css file. 
> But then I said I wouldn't touch anything else until the next 
> release :) :)
>  
> > Can we check whether the launching user is a local admin in the NSI 
> > script?
> > I don't know how that works, but I can look into it.
> > 
> 
> It looks like there might be with NSIS 2.0. Take a look at 
> the 'UserInfo' plugin.  Here's a snippet I found at:
> 
> http://cvs.sourceforge.net/viewcvs.py/popfile/windows/adduser.
> nsi?rev=1.17
> 
> get_usertype:
>   UserInfo::GetAccountType
>       Pop $G_WINUSERTYPE
>   StrCmp $G_WINUSERTYPE "Admin" exit
>   StrCmp $G_WINUSERTYPE "Power" exit
>   StrCmp $G_WINUSERTYPE "User" exit
>   StrCmp $G_WINUSERTYPE "Guest" exit
>   StrCpy $G_WINUSERTYPE "Unknown"
> 
> exit:
> 
> Brent



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
Archive: https://lists.sourceforge.net/lists/listinfo/dqsd-devel

Reply via email to