Feature Requests item #665462, was opened at 2003-01-09 18:58
Message generated for change (Settings changed) made by shawnkhall
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=432069&aid=665462&group_id=42081

Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add user-settable "Features" parameter to window.open calls

Initial Comment:
Add user-settable "Features" parameter to window.open 
calls:

I've done it in my own installation. I've defined a localpref 
like:

gWindowOpenOptions 
= "directory=no,location=yes,menubar=yes,resizable=ye
s,scrollbars=yes,status=yes,titlebar=yes,toolbar=yes";

and then in defer_tools.js, I've changed to window.open 
call syntax from:

    window.open(url, name);

to

    window.open(url, name, gWindowOpenOptions);

This way I can hide the "Links" bar that doesn't show up 
in my IE windows, as I've turned it off. But the default 
value for "directory" is "yes/1" in window.open() method 
so it keeps showing up in my searches. 

I've hoped to take care of it through 
pagetemplate/maximized.htm but there doesn't seem to 
be a way to hide the Links bar for the current window, so 
that doesn't work.

I don't want to keep changing defer_tools.js with every 
upgrade, so please consider this flexibility for your next 
release. Thanks!

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-05-12 15:28

Message:
Logged In: NO 

Sorry for the duplicate entry. The first one didn't show up 
initially even though I've refreshed the page. Admins, can you 
please delete on of the copies, along with this comment?

Thanks!

 Ozgur

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-05-12 15:22

Message:
Logged In: NO 

Thanks for adding this feature in. I can see that it's there in 
3.1.6. But unfortunately it came with a bug (or something in 
my system is messing it up a bit). The problem happens in:

submitForm(form, dontChangeTarget)

function. In this function, I guess the code to handle the 
new "windowOpenFeatures" local preference was copied from 
the functions above in which they have "url" defined. This 
function however, doesn't have that variable defined, and ends 
up in a "not defined" run-time error, when I run a "search" 
like "table:" (w/o the quotes) to get to M-Webster dictionary.

I've changed the window.open lines to this to fix the problem:

      if (typeof windowOpenFeatures != "undefined") {
        w = window.open(pagetemplate, newtarget, 
windowOpenFeatures);
      } else {
        w = window.open(pagetemplate, newtarget);
      }

Please fix the problem in the next version. Thanks!

 Ozgur

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-05-12 15:21

Message:
Logged In: NO 

Thanks for adding this feature in. I can see that it's there in 
3.1.6. But unfortunately it came with a bug (or something in 
my system is messing it up a bit). The problem happens in:

submitForm(form, dontChangeTarget)

function. In this function, I guess the code to handle the 
new "windowOpenFeatures" local preference was copied from 
the functions above in which they have "url" defined. This 
function however, doesn't have that variable defined, and ends 
up in a "not defined" run-time error, when I run a "search" 
like "table:" (w/o the quotes) to get to M-Webster dictionary.

I've changed the window.open lines to this to fix the problem:

      if (typeof windowOpenFeatures != "undefined") {
        w = window.open(pagetemplate, newtarget, 
windowOpenFeatures);
      } else {
        w = window.open(pagetemplate, newtarget);
      }

Please fix the problem in the next version. Thanks!

 Ozgur

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-01-15 20:00

Message:
Logged In: NO 

this is done - should be in the next version after 3.1.5

----------------------------------------------------------------------

Comment By: mll (mlmll)
Date: 2003-01-10 00:03

Message:
Logged In: YES 
user_id=491129

Weird. I also hid the links in IE, and, whether it's called from 
DQSD or started by hand, I have the exact same layout in IE.

MLL

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=432069&aid=665462&group_id=42081


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Archive: https://lists.sourceforge.net/lists/listinfo/dqsd-devel

Reply via email to