Hi Shawn,
On Fri, Aug 8, 2008 at 02:27, Shawn K. Hall <[EMAIL PROTECTED]> wrote:
>
> We'll need to include the users' personal stylesheet as well, though, as
> it's important to be able to style it for when the default doesn't work
> for you.
Yes, that's already in place, right? I think there's a <style> tag
just below the theming in search.htm that brings in the user's
localsearch.css.
> Of course, if we used a standard naming convention, we might be able to
> avoid that as well. :)
>
> Something like ("/themes/%themename%/")
> ./style.css - default stylesheet applied 100% of the time
> ./single.css - stylesheet imported when DQSD is on a single-row
> taskbar
> ./multiple.css - stylesheet imported when DQSD is on a multi-row
> taskbar
Looks cool. Is there a possibility for some kind of re-use between
single.css and multiple.css? @import might do it, but I don't know
enough CSS to talk myself out of a web conference :)
> Easier JS code would be something like:
>
> <script type='text/jscript'>
> document.write("<style type='text/css'>");
> document.write("@import url(./themes/" + sanitize(themename) + "/" +
> (multiline ? 'multiple' : 'single') + ".css);");
> document.write("</style>");
> </script>
Nice! I'd rather extract the entire URL building into a function,
though, to get rid of some complexity in search.htm.
> This would require that the "themename" be stored somewhere within the
> user preferences script (which would default to something useful within
> the global prefs). Instead of duplicating the stylesheet when a new one
> is selected, the themename can be drawn from a new script file which
> consists of only:
> themename="whatever";
At first I preferred the duplication, because I think generating JS at
run-time is scary, but this solution becomes much easier to handle;
- we can set themename="classic" by default in prefs.js or similar, so
if theme.js is missing, it just works.
- theme.js is easy to generate from the menu handling code, especially
since we have all the necessary functions in the launcher (I think)
So, I think this makes sense, as long as we place theme.js in
%appdata% and include it into search.htm from there.
> Also, the "sanitize" function doesn't exist yet, but it would strip out
> all characters that didn't match "[a-z0-9\s\.\-]", in order to prevent
> something from using DQSD as an infection or escalation vector in the
> future.
Good plan!
> If we can agree on a structure, I'll happily rewrite and reorg the
> themes.
I think we agree :)
- Kim
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Archive: https://lists.sourceforge.net/lists/listinfo/dqsd-devel