Hello,
I tried to compile drbd 8.3.3RC against kernel source 2.6.31.1-3, I get
a compile error.
Sources obtained from http://oss.linbit.com/drbd/8.3/drbd-8.3.3rc3.tar.gz
++++++++++ compile error +++++++++++
CC [M] /root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.o
/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c: In function
â_drbd_start_io_acctâ:
/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c:64: error: lvalue
required as increment operand
/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c: In function
â_drbd_end_io_acctâ:
/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c:86: error: lvalue
required as decrement operand
make[6]: *** [/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.o]
Error 1
make[5]: *** [_module_/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd] Error 2
make[4]: *** [sub-make] Error 2
make[3]: *** [all] Error 2
++++++++++ compile error +++++++++++
solution
based on this patch but only for lines 64 and 86
"diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
index cbdc257..0656cf1 100644
--- a/drivers/block/drbd/drbd_req.c
+++ b/drivers/block/drbd/drbd_req.c
@@ -42,7 +42,7 @@ static void _drbd_start_io_acct(struct drbd_conf *mdev,
struct drbd_request *req
part_stat_inc(cpu, &mdev->vdisk->part0, ios[rw]);
part_stat_add(cpu, &mdev->vdisk->part0, sectors[rw], bio_sectors(bio));
part_stat_unlock();
- mdev->vdisk->part0.in_flight++;
+ mdev->vdisk->part0.in_flight[rw]++;
}
/* Update disk stats when completing request upwards */
@@ -55,7 +55,7 @@ static void _drbd_end_io_acct(struct drbd_conf *mdev, struct
drbd_request *req)
part_stat_add(cpu, &mdev->vdisk->part0, ticks[rw], duration);
part_round_stats(cpu, &mdev->vdisk->part0);
part_stat_unlock();
- mdev->vdisk->part0.in_flight--;
+ mdev->vdisk->part0.in_flight[rw]--;
}
static void _req_is_done(struct drbd_conf *mdev, struct drbd_request *req, const int
rw)"
mfg,
jeroen
_______________________________________________
drbd-user mailing list
drbd-user@lists.linbit.com
http://lists.linbit.com/mailman/listinfo/drbd-user