When I start X on a kernel where agpgart is included but no gart
device is found, X oopses on a null pointer dereference in radeon_ioremap.
The attached patch avoids the oops, but should be reviewed by
someone more knowledgeable about DRM than I.
-- 
Bjorn Helgaas - [EMAIL PROTECTED]
Linux Systems Operation R&D
Hewlett-Packard


diff -u -r -X /home/helgaas/exclude linux-hplso/drivers/char/drm/drm_memory.h 
linux/drivers/char/drm/drm_memory.h
--- linux-hplso/drivers/char/drm/drm_memory.h   Thu Jan 24 20:41:32 2002
+++ linux/drivers/char/drm/drm_memory.h Thu Jan 24 21:16:23 2002
@@ -322,7 +322,7 @@
        }
 
 #if __REALLY_HAVE_AGP
-       if(dev->agp->cant_use_aperture == 0)
+       if(!dev->agp || dev->agp->cant_use_aperture == 0)
                goto standard_ioremap;
 
        list_for_each(list, &dev->maplist->head) {
@@ -382,7 +382,7 @@
                DRM_MEM_ERROR(DRM_MEM_MAPPINGS,
                              "Attempt to free NULL pointer\n");
 #if __REALLY_HAVE_AGP
-       else if(dev->agp->cant_use_aperture == 0)
+       else if(!dev->agp || dev->agp->cant_use_aperture == 0)
 #else
        else
 #endif

_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to