Am Mittwoch, 8. Januar 2003 22:27 schrieb Linus Torvalds: > Grr. Double-grr. That assembly-language is written in some unreadable > syntax anyway, but here's a totally untested diff that may fix the crap by > de-allocating the stack only after we're actually _done_ with it. > > I was too lazy to check whether the other asm routines were similarly > broken. Anyway, the rule is: > > YOU MUST NOT USE LOCATIONS ON THE STACK UNDER THE STACK POINTER > > Ok, I feel better now after that rant. Sorry,
You are a hero! As always you made my day. I've tested it with DRI CVS trunk and MesaCVS (5.1) on my dual Athlon MP. All FPU sigfaults are fixed. Ugh, if I only could understand x86 asm somewhat better. I've learned on 68k...;-) Any pointers how I can solve such problems next time for my self? How did you do it? Now, Petr have some "cleanups/speedups" handy. I'll give them a try. Regards and thank you very much. -Dieter PS One obstacle fewer to get Mesa 5.0 into XFree CVS (4.3.0). PPS What about the texmem branch? > ----- > Index: common_x86_asm.S > =================================================================== > RCS file: /cvsroot/dri/xc/xc/extras/Mesa/src/X86/common_x86_asm.S,v > retrieving revision 1.16 > diff -u -r1.16 common_x86_asm.S > --- common_x86_asm.S 25 Nov 2002 19:57:08 -0000 1.16 > +++ common_x86_asm.S 8 Jan 2003 21:27:57 -0000 > @@ -225,13 +225,13 @@ > > MOVUPS ( REGIND( ESP ), XMM1 ) > > - ADD_L ( CONST( 32 ), ESP ) > - > DIVPS ( XMM0, XMM1 ) > > /* Restore the original MXCSR register value. > */ > LDMXCSR ( REGOFF( -4, EBP ) ) > + > + ADD_L ( CONST( 32 ), ESP ) > > LEAVE > RET ------------------------------------------------------- This SF.NET email is sponsored by: SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! http://www.vasoftware.com _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
