[Dri-devel] X86 code-gen question

[Ian Romanick]

I'm about to commit some minor changes to the X86 code-gen in the Radeon & R200 drivers. The primary focus is adding SSE assembly stubs.

There is one minor change that I'd like to make to the generic X86 stubs. There are two functions that do exactly the same thing, but with a different name. They are _x86_Normal3fv and _x86_Color3fv_3f (and the non-v versions of both). I'd like to condense this down into a single _x86_Generic3fv, which is what I created for the SSE versions. My quesion is which stub should I use as the basis of _x86_Generic3fv? Both are shown below. If I'm not mistaken, the first is 0x1E bytes and the second is 0x1A bytes, if that matters...

GLOBL( _x86_Normal3fv)
movl 4(%esp), %eax /* load 'v' off stack */
movl (%eax), %ecx /* load v[0] */
movl 4(%eax), %edx /* load v[1] */
movl 8(%eax), %eax /* load v[2] */
movl %ecx, 0 /* store v[0] to current vertex */
movl %edx, 4 /* store v[1] to current vertex */
movl %eax, 8 /* store v[2] to current vertex */
ret
GLOBL ( _x86_Normal3fv_end )

GLOBL( _x86_Color3fv_3f )
movl 4(%esp), %eax
movl $0, %edx
movl (%eax), %ecx
movl %ecx, (%edx)
movl 4(%eax), %ecx
movl %ecx, 4(%edx)
movl 8(%eax), %ecx
movl %ecx, 8(%edx)
ret
GLOBL( _x86_Color3fv_3f_end )



-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel