>>>>> On Tue, 26 Aug 2003 17:58:55 +0200, Benjamin Herrenschmidt <[EMAIL PROTECTED]>
>>>>> said:
Benjamin> flush_tlb_kernel_range((unsigned long) addr, (unsigned long) addr + size);
Benjamin> Why this flush ? I don't see why one would need to flush
Benjamin> TLBs on a region obtained from vmap()... vmap will give
Benjamin> you virtual addresses that weren't allocated before, so
Benjamin> that shouldn't be in your tlb (if they were used by a
Benjamin> previous vmalloc, then vfree would have cleared them...
Yes, I think you're right. I checked my earlier patches and the
flush_tlb_kernel_range() was there as early as 9/28/2002 and shouldn't
have been needed even then (things worked differently then, but
eventually, it called vunmap() which also flushes the TLB). I suspect
when I wrote the code I just forgot that vfree/vunmap take care of
flushing the TLB.
Thanks for catching this.
--david
-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines
at the same time. Free trial click here:http://www.vmware.com/wl/offer/358/0
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel
