I just checked and we have trailing blanks all over the place in the kernel tree too. Instead of just fixing the trailing blanks maybe we should bite the bullet and run indent over everthing. There are about 1,500 lines with trailing white space. You don't lose the blame annotations, you just have to dig a little deeper to find them.
If we go the ident route we can make it a requirement to run it before checking anything in. I'd prefer that route since it enforces style rules. There's an approved set of parameters for using ident on the kernel somewhere. On Wed, 8 Sep 2004 00:47:24 +0100 (IST), Dave Airlie <[EMAIL PROTECTED]> wrote: > > > I used sed: > > sed -e 's/[ ]*$//' < $TMP > $1 > > > > to strip the trailing white space from all of the DRM files. > > Any objections to a check in? Kernel rules for patches are no trailing > > white space. > > Hold off for a while, the problem with this is generating diffs against > the kernel gets messy, if we do it I think it needs to happen to both > trees at once, there are a lot of whitespace issues in the DRM, one > superpatch is waay more acceptable from a version control point of view.. > (Larry says you should never do whitespace fixes using BK unless you > happen to be working on the code in that area... as you lose blame > annotations for pieces of code).. > > Dave. > > -- > David Airlie, Software Engineer > http://www.skynet.ie/~airlied / airlied at skynet.ie > pam_smb / Linux DECstation / Linux VAX / ILUG person > > -- Jon Smirl [EMAIL PROTECTED] ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
